Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic - Recovery & Refreshing #188

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Epic - Recovery & Refreshing #188

wants to merge 22 commits into from

Conversation

piotr-roslaniec
Copy link

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Other

Required reviews:

How many reviews does the PR author need?

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

piotr-roslaniec and others added 18 commits March 19, 2024 10:30
@piotr-roslaniec
refactor: avoid using crypto primitives directly, part 1
8b26396
@piotr-roslaniec
refactor: avoid using crypto primitives directly, part 2
cfa8c99
@piotr-roslaniec
feature: introduce refreshing api in ferveo
4713848
@piotr-roslaniec
feature!: remove state from dkg, part 1
315d2b4
@piotr-roslaniec
feature!: remove state from dkg, part 2
c9f1adc
@piotr-roslaniec
refactor: rename public key share to public key
0ef7de4
@piotr-roslaniec
refactor: update serde serialization
ba12d6b
@piotr-roslaniec
refactor: hide g_inv from internat apis
b67aef9
@piotr-roslaniec
feature: remove deprecated exceptions
93807a2
@cygnusv
Merge pull request #175 from piotr-roslaniec/rewrite-refreshing
2c97934 
Key share refreshing ceremony refactor
@piotr-roslaniec
feature: introduce refreshing api in ferveo
0117a87
@piotr-roslaniec
test: document domain point determinism
9aca6ae
@piotr-roslaniec
test: fix tests sensitive to message ordering
4a8375d
@piotr-roslaniec
fix: not using subset of participants in precomputed variant
975dae0
@piotr-roslaniec
Merge pull request #182 from piotr-roslaniec/domain_points
703cbdd 
Document domain points determinism in DKG instances
@piotr-roslaniec
Merge pull request #183 from piotr-roslaniec/remove-dkg-state
aa69b36 
Remove statefullness from DKG instances
@cygnusv
Merge pull request #185 from piotr-roslaniec/aggregate-from-subset
299a471 
Create an aggregate from subset of messages
@piotr-roslaniec
chore: fix a bad rebase
dc2f167
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.46498% with 79 lines in your changes are missing coverage. Please review.

Project coverage is 80.13%. Comparing base (2fe8753) to head (b72a338).

Files Patch % Lines
ferveo/src/api.rs 94.34% 38 Missing ⚠️
ferveo/src/bindings_python.rs 61.11% 14 Missing ⚠️
ferveo/src/bindings_wasm.rs 0.00% 12 Missing ⚠️
ferveo/src/dkg.rs 96.50% 5 Missing ⚠️
ferveo/src/refresh.rs 98.54% 5 Missing ⚠️
ferveo-tdec/src/key_share.rs 50.00% 3 Missing ⚠️
ferveo-common/src/keypair.rs 0.00% 1 Missing ⚠️
ferveo/src/pvss.rs 99.20% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   78.16%   80.13%   +1.96%     
==========================================
  Files          24       24              
  Lines        5222     5588     +366     
==========================================
+ Hits         4082     4478     +396     
+ Misses       1140     1110      -30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-roslaniec @codecov-commenter @cygnusv